The Community Forums

Interact with an entire community of cPanel & WHM users!
  1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Add-on Domain Deletion

Discussion in 'General Discussion' started by VeZoZ, Apr 15, 2009.

  1. VeZoZ

    VeZoZ Well-Known Member

    Joined:
    Dec 14, 2002
    Messages:
    248
    Likes Received:
    0
    Trophy Points:
    16
    cPanel Access Level:
    DataCenter Provider
    I'm not sure what version this was added but when add-on domains are removed from a cPanel account it does a stats run on the account. This is great idea to make sure a users bandwidth and such are accurate. However I don't think it was thought through the implementation. It does a complete stats run of the account not just the specific domain. So here's a situation that happens:

    User had 10 add-on domains on their account and they're removing 5. They remove one after another within a minute they now have 5 stacked stats processes. I don't think these processes even follow the cpuwatch so they just sky rocket server load as I doubt many expect to have numerous stats runs going on at the same time so no one is going to compensate for this situation.

    I think the best solution is to add a feature to the stats run script to process only a specific domain on an account. This would help with this problem there is no point in running it for the entire account.

    The other way is maybe adding some sort of queue system or check if there is one already running don't start another.

    This feature really needs to be improved upon. It just causes way too much system resource strain at this time due to the lack of limitations on it.
     
  2. cPanelDavidG

    cPanelDavidG Technical Product Specialist

    Joined:
    Nov 29, 2006
    Messages:
    11,279
    Likes Received:
    8
    Trophy Points:
    38
    Location:
    Houston, TX
    cPanel Access Level:
    Root Administrator
    These statistics processes should be observing the limits enforced by cpuwatch. If you are seeing significant strain on your server as a result of this happening, please let our technical analysts look into this for you: http://tickets.cpanel.net/submit

    Also, having our technical analysts look at your server can help expedite any improvements that can be done to our software to further optimize this process.
     
  3. VeZoZ

    VeZoZ Well-Known Member

    Joined:
    Dec 14, 2002
    Messages:
    248
    Likes Received:
    0
    Trophy Points:
    16
    cPanel Access Level:
    DataCenter Provider

    Well I'll make a ticket but I have many servers and this can be observed on any of them. I'll just give you guys access to one.

    I'm really skeptical this change was thought through which is very frustrating. All it takes is one user with a bunch of add-on domains to start removing them one after another and it'll bring a server to it's knees. Even if CPU watch is working it's an inefficient process to be doing the stats run for the entire account when the intention is to clear out the logs and bandwidth for just one of the domains.
     
  4. cPanelDavidG

    cPanelDavidG Technical Product Specialist

    Joined:
    Nov 29, 2006
    Messages:
    11,279
    Likes Received:
    8
    Trophy Points:
    38
    Location:
    Houston, TX
    cPanel Access Level:
    Root Administrator
    I talked to our quality assurance team about this. In a quick 5 minute glance at what is done upon a deletion of an add-on domain, they didn't notice anything that would trigger a stats run. However, this does not negate the possibility of stats runs being initiated for each deleted add-on domain. There are other things that can trigger tasks to be performed upon performing a specific action (e.g. removal of an add-on domain), so our technical analysts can look for possible causes of this behavior more swiftly than I can attempt to speculate what the cause may be. If it does turn out to be an issue with our code, our technical analysts will be able to present this information to our quality assurance team for them to act upon. That's why I'm recommending having our technical analysts assist you.
     
  5. VeZoZ

    VeZoZ Well-Known Member

    Joined:
    Dec 14, 2002
    Messages:
    248
    Likes Received:
    0
    Trophy Points:
    16
    cPanel Access Level:
    DataCenter Provider

    I have an open ticket about it and so far it's been confirmed that it does a stats run on the account upon each add-on domain or subdomain removal. So I guess the questions are

    1. Is cpuwatch working properly
    2. Should there be a design change to prevent multiple ones running
    3. Should the stats processing have the ability to only process one subdomain/domain rather than an entire account to reduce load as it's only necessary to stats run the subdomain removed not every single one.


    We'll see where the ticket goes on this issue.
     
  6. cPanelDavidG

    cPanelDavidG Technical Product Specialist

    Joined:
    Nov 29, 2006
    Messages:
    11,279
    Likes Received:
    8
    Trophy Points:
    38
    Location:
    Houston, TX
    cPanel Access Level:
    Root Administrator
    Can you PM me your ticket number so I can follow-up internally with this?
     
  7. VeZoZ

    VeZoZ Well-Known Member

    Joined:
    Dec 14, 2002
    Messages:
    248
    Likes Received:
    0
    Trophy Points:
    16
    cPanel Access Level:
    DataCenter Provider
    Six months later and I don't think this is still fixed? The 11.25 change logs have no mention of it so I assume that's so. It's a really awful bug in my opinion. People delete add-on domains all the time and some do it in bunches. So we get a bunch of stats runs for the same thing. It probably should also be doing a queue of the restarts of the web server as well...
     
  8. cPanelDavidG

    cPanelDavidG Technical Product Specialist

    Joined:
    Nov 29, 2006
    Messages:
    11,279
    Likes Received:
    8
    Trophy Points:
    38
    Location:
    Houston, TX
    cPanel Access Level:
    Root Administrator
    Regarding the issue of addon domain deletion causing stats runs (internal case 26118), the resolution for this issue is still being tested, but is present in BETA build 40392. I have no exact ETA on when this will propagate to production worthy builds, but this is actively being worked on.

    Apache restarts are queued in 11.25 using queueprocd, to minimize the number of times Apache is restarted. This functionality is mentioned at: cPanel 11.25
     
  9. cPanelKenneth

    cPanelKenneth cPanel Development
    Staff Member

    Joined:
    Apr 7, 2006
    Messages:
    4,458
    Likes Received:
    22
    Trophy Points:
    38
    cPanel Access Level:
    Root Administrator
    Clarification

    To clarify what DavidG wrote: not all Apache restarts are queued. Only a few select restarts are queued - mainly those triggered by the Tweak Settings interface.

    For this particular issue, removal of addon domains triggering a stats run, this is addressed in cPanel 11.25.1 and is being evaluated for back merge into 11.25.0. The fix entails using the task queue, an 11.25 feature, to handle the stats processing triggered by the removal of an addon domain. Multiple requests for stats processing in a short duration will be handled as a single event.
     
Loading...

Share This Page