In Progress CPANEL-41073 - new update in cPHulk adding IP's to white list or Blacklist does not flag already listed IP's?

Spirogg

Well-Known Member
Feb 21, 2018
700
160
43
chicago
cPanel Access Level
Root Administrator
Hello I know this is just an Edge Version
cPanel & WHM v105.9999.82

but it seems when you add an IP
then add the same IP again it just says it added it to the list.
but it should flag it as already listed
the other new thing is the # comments
so if you add IP 10.10.10.10 # add your comment here
then add the same IP with out a comment it removes the comment from it originally. where it should flag the IP has been listed,

the old way was nicer to just update the comment if needed.
which I see if we click edit we can just add a comment as well.

so if we have a listed IP already and we try to add that IP again it should not remove the comment and be flagged as already listed,



we need to have a flag ( not allow for the update to happen and remove the comments and if there are no # comments then you would need to add the IP
( example ) > 10.10.10.10 # new comment and the it would allow to add the comment to the IP


so my example is I added 5 IP's with a comment 2 months ago
then today from another server I download the list of blacklisted IP's and want them to go to this servers, (blacklist)
happens to be 5 of the IPs in my list are already listed with comments and now I copy and paste the list not knowing that 5 of the IP's are already listed
and it wipes out my comments that I had posted.

it should not allow that. should throw a flag that those IP's are already listed,

the only thing it should allow is if you want to add a comment to a certain IP it will add it only if you use the format 10.10.10.10 # new comment.

also another weird thing is when you add a list of IPs copy and paste then click add,
then copy and paste again the same IP's at first it shows as if you added more but after a refresh the number goes back to just one list.

example
copy and paste 100 IP's then copy and paste the same IP's now it shows as 200 IP's when they really are just 100
after you refresh the page then it shows the correct amount of 100.

so some how you need to fix this so when you click add the second time it will show you the correct number 100 and not 200. we should not have to refresh the page to note that it was only 100 IP's


lets just say 100 IPs in your list and then 50 ip;s in another list but 20 are the same in the first list.
after uploading the first 100 the the 50 it shows 150 but after refresh it will show 130

so a little confusing until a refresh.

Thanks just my opinion and notice this today after testing.

PS the top bar looks nice and the feature to edit your favorites is nicely done, :)

Spiro
 
Last edited:

Spirogg

Well-Known Member
Feb 21, 2018
700
160
43
chicago
cPanel Access Level
Root Administrator
Hello I know this is just an Edge Version
cPanel & WHM v105.9999.82

but it seems when you add an IP
then add the same IP again it just says it added it to the list.
but it should flag it as already listed
the other new thing is the # comments
so if you add IP 10.10.10.10 # add your comment here
then add the same IP with out a comment it removes the comment from it originally. where it should flag the IP has been listed,

the old way was nicer to just update the comment if needed.
which I see if we click edit we can just add a comment as well.

so if we have a listed IP already and we try to add that IP again it should not remove the comment and be flagged as already listed,



we need to have a flag ( not allow for the update to happen and remove the comments and if there are no # comments then you would need to add the IP
( example ) > 10.10.10.10 # new comment and the it would allow to add the comment to the IP


so my example is I added 5 IP's with a comment 2 months ago
then today from another server I download the list of blacklisted IP's and want them to go to this servers, (blacklist)
happens to be 5 of the IPs in my list are already listed with comments and now I copy and paste the list not knowing that 5 of the IP's are already listed
and it wipes out my comments that I had posted.

it should not allow that. should throw a flag that those IP's are already listed,

the only thing it should allow is if you want to add a comment to a certain IP it will add it only if you use the format 10.10.10.10 # new comment.

also another weird thing is when you add a list of IPs copy and paste then click add,
then copy and paste again the same IP's at first it shows as if you added more but after a refresh the number goes back to just one list.

example
copy and paste 100 IP's then copy and paste the same IP's now it shows as 200 IP's when they really are just 100
after you refresh the page then it shows the correct amount of 100.

so some how you need to fix this so when you click add the second time it will show you the correct number 100 and not 200. we should not have to refresh the page to note that it was only 100 IP's


lets just say 100 IPs in your list and then 50 ip;s in another list but 20 are the same in the first list.
after uploading the first 100 the the 50 it shows 150 but after refresh it will show 130

so a little confusing until a refresh.

Thanks just my opinion and notice this today after testing.

PS the top bar looks nice and the feature to edit your favorites is nicely done, :)

Spiro
@cPRex
@cPanelWilliam

Wondering if you have noted this and tested and if there will be a solution and or compromise ?
 

Spirogg

Well-Known Member
Feb 21, 2018
700
160
43
chicago
cPanel Access Level
Root Administrator
Hey hey! I just tried this with 105.9999.82 and see it working well:

View attachment 78813

Was there a particular operating system you were using?
Hi @cPRex
You miss understood me. It’s not adding an ip to server it’s in cPHulk black list and white listing. Ip’s

if you already have an ip listed with a comment it deletes the comment.
When you add an ip to either black list or white list and then add the same ip again it says it added the ip?
it should flag it as listed with or with out comment and not allow it.

Only if you edit you can add a comment afterwards.
Thanks test that please. Both Ubuntu and AlmaLinux
 

Spirogg

Well-Known Member
Feb 21, 2018
700
160
43
chicago
cPanel Access Level
Root Administrator
Ah, I saw cPHulk in the title, but then got distracted!

I made CPANEL-41073 for this one, so it's on their radar now!
Thanks. We miss you when your off :)
 
  • Like
Reactions: cPRex