cPanel Themes, Icons, and you!

[stormy]

Not really, sorry! I appreciate your help here, by the way. I can post the line that got removed:

/scripts/postupcp_icons # restore old icons

That's the actual line that gets deleted by upcp. If I remove the comment, it gets deleted too.

There are many ways around this so it's really not worth it to bother. I can run my fixes from other scripts, from the cron, manually whenever I feel like, etc. No big deal!

 

[PeteS]

/scripts/upcp is actively searching for "/usr/local/cpanel/scripts/postupcp_icons" inside /scripts/postupcp and removing that line if found.

How?

I just checked /scripts/upcp on a server and don't see that search:

# cat /scripts/upcp | grep postupcp
if ( -x '/usr/local/cpanel/scripts/postupcp' ) {
$logger->info("Running /usr/local/cpanel/scripts/postupcp");
system '/usr/local/cpanel/scripts/postupcp';

...and there is nothing in postupcp that would mess with anything, so I don't see how that is happening for you.

 

[stormy]

It started to happen with cPanel 110.0.5. I just verified it again.

EDIT: I found it and it's not a cPanel caused issue. It's a side effect of a Cloudlinux script that is called by upcp: /usr/local/cpanel/bin/cloudlinux_cleanoldhooks

It's removing lines with postupcp in them:

        deleteAllInclude "$postupcp" "postupcp" "/#cpanel-lve/d"
        deleteAllInclude "$postupcp" "postupcp" "/#CloudLinux/d"

Mystery solved! And sorry for the confusion caused.

I'm happy that nobody at cPanel spent time trying to interfere with this!!! And sorry for the confusion and wasting your time @PeteS and @cPRex

 

[PeteS]

It started to happen with cPanel 110.0.5. I just verified it again. I'm not motivated enough to go through all the scripts that are called by upcp to see where the developers hid the code. Really, I applaud the effort - it's funny! :D

I'm on 110.0.5.

Just now:
I created /scripts/postupcp_icons and placed the call in /scripts/postupcp
After running /scripts/upcp the line is still in /scripts/postupcp, and /scripts/postupcp_icons still exists and executes.

I'll check again in a day to see if the line still exists.

I'm running a standard profile cPanel server, no CL or any abnormal mods. If upcp removes that line for you then something is odd indeed.

 

[stormy]

Thanks. It's Cloudlinux that's adding a call to /usr/local/cpanel/bin/cloudlinux_cleanoldhook inside the upcp process. Nothing cPanel related. Thanks everyone for the investigation!